Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(readme,website): update assets and fix search bug #996

Merged
merged 5 commits into from
Feb 4, 2022

Conversation

sandren
Copy link
Collaborator

@sandren sandren commented Feb 4, 2022

This adds the Jotai mascot to the project README file and consolidates all of Jotai's brand assets into the ./img directory for others to easily download, but elsewhere consumes the same files from Google Cloud Storage for improved caching. 🙂

It also fixes a bug on the website where an empty query would still display search results.

@vercel
Copy link

vercel bot commented Feb 4, 2022

@sandren is attempting to deploy a commit to the Poimandres Team on Vercel.

A member of the Team first needs to authorize it.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 4, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 53a9477:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration

@sandren sandren changed the title feat(branding): update assets fix(readme,website): update assets and fix search bug Feb 4, 2022
@vercel
Copy link

vercel bot commented Feb 4, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/jotai/GwBwTDw1AyKBcfhFLnfYyTvEckJ7
✅ Preview: https://jotai-git-fork-cndycd-feat-branding-pmndrs.vercel.app

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dai-shi dai-shi merged commit fb3f906 into pmndrs:main Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants