Add eslint, stylelint, prettier, and pre-commit #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When you try to commit, Pre-commit will run checks for all three, if installed, _only_ on staged files, and prevent committing if the linters are unhappy. - Several eslint rules that generate a lot of errors are disabled for now. That's to allow a more gradual transition, so you won't change 1 line and be told to fix 100 other lines (but maybe like 20 because there are still a lot of rules enabled). - Prettier is set to require pragma. That's also to allow a more gradual transition. As each file is tidied up, run Prettier on it, and it'll add a special comment that tells it that it's now responsible for keeping that one tidy.
|
Thanks! |
oliver-kriska
pushed a commit
to payout-one/analytics
that referenced
this pull request
Dec 23, 2020
- When you try to commit, Pre-commit will run checks for all three, if installed, _only_ on staged files, and prevent committing if the linters are unhappy. - Several eslint rules that generate a lot of errors are disabled for now. That's to allow a more gradual transition, so you won't change 1 line and be told to fix 100 other lines (but maybe like 20 because there are still a lot of rules enabled). - Prettier is set to require pragma. That's also to allow a more gradual transition. As each file is tidied up, run Prettier on it, and it'll add a special comment that tells it that it's now responsible for keeping that one tidy.
|
The prettier config on this is broken currently, for whatever reason, this fixes it; #2150 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
installed, only on staged files, and prevent committing if the linters are
unhappy.
That's to allow a more gradual transition, so you won't change 1 line and be
told to fix 100 other lines (but maybe like 20 because there are still a lot
of rules enabled).
transition. As each file is tidied up, run Prettier on it, and it'll add a
special comment that tells it that it's now responsible for keeping that one
tidy.
Oh, and Pre-commit supports custom hooks, too, though there is already one for
mix formatandmix test. It's the language-agnostic choice for git pre-commit hooks.Tests
Changelog
Documentation