Count pending ownership sites towards account usage on the upgrade page #4277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When the user goes to upgrade to a plan, currently we let them upgrade to a suitable plan based on the usage across their owned sites. When the user has pending ownerships however, they might not be able to accept them, even after upgrading to a seemingly suitable plan, which can be annoying/confusing.
Whenever there are pending site ownerships, a message will be shown to the user:
Counting the usage from pending ownerships means that we are not letting them upgrade to a plan that would not accommodate all the pending sites. Same goes for warning about losing access to a feature used be a pending ownership site.
Tests
Changelog
Documentation
Dark mode