Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update runtime to elixir-1.17.1 and erlang-27.0 #4255

Merged
merged 5 commits into from
Jun 24, 2024
Merged

Conversation

ruslandoga
Copy link
Contributor

@ruslandoga ruslandoga commented Jun 20, 2024

Changes

This PR updates Elixir to 1.17 and Erlang to 27 mostly to bring in Duration. I picked the base image with the smallest alpine version difference (3.18.6 vs 3.18.4) but we can update it as well (to 3.20).

mjml_eex (akoutmos/mjml_eex#19) and credo had to be updated to make them work again.

Warnings from the new Elixir type checker for phoenix_live_view failed CI tests so I backported phoenixframework/phoenix_live_view@489e8de in 0d07f4d. This workaround can be removed once Plausible starts using phoenix_live_view 1.0.0 (currently in rc).

There are warnings from ex_money and phoenix_view too but they don't seem to fail CI so I left them as is.
Later ex_money can be updated to 5.17.0 and phoenix_view -- to 2.0.4.

Tests

  • Tests have been adapted

Changelog

  • This PR does not make a user-facing change

Documentation

  • This change does not need a documentation update

Dark mode

  • This PR does not change the UI

@ruslandoga ruslandoga requested review from a team June 20, 2024 16:56
@ruslandoga ruslandoga marked this pull request as draft June 20, 2024 17:12
@ruslandoga ruslandoga removed request for a team June 20, 2024 17:16
@ruslandoga ruslandoga marked this pull request as ready for review June 22, 2024 17:07
@ruslandoga ruslandoga requested review from a team June 22, 2024 17:07
@aerosol aerosol added deploy-to-staging Special label that triggers a deploy to a staging environment preview labels Jun 24, 2024
@aerosol aerosol merged commit 5a0718a into master Jun 24, 2024
12 of 14 checks passed
@aerosol aerosol deleted the elixir-1-17-otp-27 branch June 24, 2024 11:22
aerosol added a commit that referenced this pull request Jun 24, 2024
aerosol added a commit that referenced this pull request Jun 24, 2024
* Update deps - follow up to #4255

* Format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-to-staging Special label that triggers a deploy to a staging environment preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants