dump buffer on invalid insert #3613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruslandoga
commented
Dec 11, 2023
| "#{System.unique_integer([:positive])}-#{Exception.message(e)}.dump" | ||
| ) | ||
|
|
||
| File.write!(path, state.buffer) |
There was a problem hiding this comment.
I'll need to test it by sending invalid row binary to the buffer. One moment.
There was a problem hiding this comment.
I tried
Plausible.Event.WriteBuffer.insert(%Plausible.ClickhouseEventV2{"meta.key": [], "meta.value": ["a"]})and it resulted in this file
998-Code: 190. DB::Exception: Elements 'meta.key' and 'meta.value' of Nested data structure 'meta' (Array columns) have different array sizes. (SIZES_OF_ARRAYS_DONT_MATCH) (version 23.3.7.5 (official build))?.dump
with the contents (passed through hexdump)
00000000 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
*
00000030 00 00 00 00 01 01 61 01 00 00 00 01 00 00 00 00 |......a.........|
00000040
aerosol
reviewed
Dec 11, 2023
| e -> | ||
| path = | ||
| Path.join( | ||
| System.tmp_dir!(), |
There was a problem hiding this comment.
let's use PERSISTENT_CACHE_DIR here with always the same file name so subsequent failures overwrite rather than pile up? One should be enough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a temporary measure to check what's going on with invalid arrays in inserts.