Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create site_user_preferences table and apply LV fix #3506

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

zoldar
Copy link
Contributor

@zoldar zoldar commented Nov 9, 2023

Changes

Changes extracted from #3469 - the migration has to be deployed and run before the changes in logic.

There's also a fix to sites LV which should address problem of excessive DB queries due to firing phx-change events on reconnecting websockets. More context: https://hexdocs.pm/phoenix_live_view/form-bindings.html#recovery-following-crashes-or-disconnects

Tests

  • Automated tests have been added
  • This PR does not require tests

Changelog

  • Entry has been added to changelog
  • This PR does not make a user-facing change

Documentation

  • Docs have been updated
  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode
  • This PR does not change the UI

@zoldar zoldar requested a review from a team November 9, 2023 09:11
@aerosol aerosol merged commit 8698b87 into master Nov 9, 2023
4 checks passed
@zoldar zoldar deleted the feat/add-site-user-preferences-and-apply-lv-fix branch November 9, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants