Fix the interval selection in the all time view #3110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if this will cause issues (again?) like described in #2713 because the daily view of all time can be quite hefty to load. |
krisbuist
force-pushed
the
fix-interval-all-time-view
branch
from
1890596
to
27b5ffe
Compare
BundleMonUnchanged files (7)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
krisbuist
force-pushed
the
fix-interval-all-time-view
branch
2 times, most recently
from
70aa75e
to
2e1dd81
Compare
Previously, the interval was always overwritten with the default value, which is determined based on the age of the site. It should not be overwritten when the interval is explicitly passed by the user
krisbuist
force-pushed
the
fix-interval-all-time-view
branch
from
2e1dd81
to
a33c663
Compare
vinibrsl
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Thank you, @krisbuist! There's still the performance issue with all time + daily interval, but this could happen with custom periods or even the year period. Let's track that in a separate issue and merge your fix. Thanks again! ✨
ruslandoga
reviewed
Aug 20, 2023
| @@ -40,6 +40,7 @@ All notable changes to this project will be documented in this file. | |||
| - Fix bug when using multiple [wildcard goal filters](https://github.com/plausible/analytics/pull/3015) | |||
| - Fix a bug where realtime would fail with imported data | |||
| - Fix a bug where the country name was not shown when [filtering through the map](https://github.com/plausible/analytics/issues/3086) | |||
| - Fix [broken interval selection](https://github.com/plausible/analytics/issues/3086) in the all time view | |||
There was a problem hiding this comment.
This should've probably gone under "Unreleased"
Reference: #2982 (comment)
Fix: #3280
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the interval was always overwritten with the default value, which is determined based on the age of the site. It should not be overwritten when the interval is explicitly passed by the user
Fixes issue #2982
Changes
The way the query is build for the given params has been edited so that the default interval for the "all" period is only set when there is no interval in the passed params
Tests
Changelog
Documentation
Dark mode