Fix date picker shifting day bug #2848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9af0428
to
25275e9
Compare
BundleMonFiles updated (1)
Unchanged files (6)
Total files change +36B 0% Final result: ✅ View report in BundleMon website ➡️ |
aerosol
reviewed
Apr 24, 2023
aerosol
approved these changes
Apr 24, 2023
ukutaht
requested changes
Apr 24, 2023
This commit fixes a bug where picking a specific date in custom range takes you to the stats of the day before. This was caused because Flatpickr returns a Date instance, and we were trying to parse this Date instance into day.js using the `utc` function, assuming it was a ISO-8601 string. This commit fixes it by casting Date into dayjs using the `dayjs` function instead of `utc`.
This commit fixes a bug where the Flatpickr was not setting the minDate correctly based on statsBegin. This was failing because parseUTCDate is now returning a day.js instance, and Flatpickr cannot handle that type.
25275e9
to
41aa321
Compare
ukutaht
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug where picking a specific date in custom range takes you to the stats of the day before.
This was caused because Flatpickr returns a Date instance, and we were trying to parse this Date instance into day.js using the
utcfunction, assuming it was a ISO-8601 string.This commit fixes it by casting Date into dayjs using the
dayjsfunction instead ofutc.