Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page and dimension filtering #1900

Closed
wants to merge 3 commits into from
Closed

Conversation

RobertJoonas
Copy link
Contributor

@RobertJoonas RobertJoonas commented May 12, 2022

Changes

  • Page path filter is now not treated as entry page filter (instead returns all sessions that have visited the page)
  • Added the entry_property filter type in the UI to filter by the entry page dimensions

Tests

  • Automated tests have been added

Changelog

  • Entry has been added to changelog

Documentation

  • Docs have been updated

@bundlemon
Copy link

bundlemon bot commented May 12, 2022

BundleMon

Files updated (1)
Status Path Size Limits
static/js/dashboard.js
287.44KB (+367B +0.12%) -
Unchanged files (6)
Status Path Size Limits
static/css/app.css
515.1KB -
static/js/app.js
12.13KB -
static/js/embed.host.js
5.58KB -
static/js/embed.content.js
5.06KB -
tracker/js/plausible.js
748B -
static/js/applyTheme.js
314B -

Total files change +367B +0.04%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@RobertJoonas RobertJoonas requested a review from ukutaht May 12, 2022 08:39
@Pixelshaped
Copy link

Hi! Really in need of that PR 👍

@RobertJoonas
Copy link
Contributor Author

Closing this in favor of #2752

@RobertJoonas RobertJoonas deleted the page-and-dimension-filtering branch May 18, 2023 10:06
@RobertJoonas RobertJoonas restored the page-and-dimension-filtering branch May 18, 2023 10:06
@RobertJoonas RobertJoonas deleted the page-and-dimension-filtering branch May 18, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants