Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Switch from pty.js to node.pty with node-pty-prebuilt #585

Closed
wants to merge 1 commit into from
Closed

Switch from pty.js to node.pty with node-pty-prebuilt #585

wants to merge 1 commit into from

Conversation

the-j0k3r
Copy link
Collaborator

@the-j0k3r the-j0k3r commented Aug 14, 2018

Supersedes #551
Rebased #551 on master + added newer node-pty-prebuilt

  • Based on node-pty-prebuilt 0.7.6
  • All Supported OS's are covered.

@ivankravets please review

@ashthespy @rustnnes

@the-j0k3r
Copy link
Collaborator Author

ping @ivankravets ;)

@ivankravets
Copy link
Member

I'll review this PR when Atom releases a new update where we will need to rebuild binaries. Please ping me when Atom will switch to new Electron.

@the-j0k3r
Copy link
Collaborator Author

@ivankravets Atom just released v1.30.0 electron 2.0.5

@ivankravets
Copy link
Member

Did they change node-module version?

@the-j0k3r
Copy link
Collaborator Author

I have no idea.

@ivankravets
Copy link
Member

I've just checked, everything works well 👍

@the-j0k3r
Copy link
Collaborator Author

Excellent, so now what?

@the-j0k3r
Copy link
Collaborator Author

@ivankravets so we good for merge and release for 2.8.5?

@the-j0k3r
Copy link
Collaborator Author

@ivankravets ping reminder for merge

@Fred-Barclay
Copy link

@the-j0k3r I was about to use this my fork (it fixes bus-stop/Termination#86 and presumably #632 here). How should I credit you? I was planning on putting you as the author in git.
Cheers!
Fred

@Fred-Barclay
Copy link

Also @ivankravets this should fix #632 so I would definitely consider merging. 😉

@the-j0k3r
Copy link
Collaborator Author

@Fred-Barclay node-pty 0.8.0 is out, however @daviwil hasnt synced node-pty-prebuilt since August, presumably busy with other projects and so on, it would be nice to get the newest prebuilt binaries in platformio-atom-ide-terminal even if at 0.7.6 it fixes a good deal of issues and is more reliable...

@ivankravets
Copy link
Member

I see that node-pty-prebuilt is not active so much. Let's back to this issue if we will have again a problem with new Atom and terminal.

@the-j0k3r
Copy link
Collaborator Author

Let's back to this issue if we will have again a problem with new Atom and terminal.

🤔

@ivankravets
Copy link
Member

@ivankravets
Copy link
Member

@the-j0k3r I would be thankful if you help with monitoring upcoming issues. If something will going wrong, I revert back latest changes.

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants