Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing built in date formatting #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

demontiejr
Copy link

Currently, the number.Format method doesn't take into consideration the formatting code. This diff implements formatting for dates based on the code.
The implementation doesn't look at the cell data type because in cases of date it's not being populated by Excel, so it's always empty.

Currently, the number.Format method doesn't take into consideration the formatting code. This diff implements formatting for dates based on the code.
The implementation doesn't look at the cell data type because in cases of date it's not being populated by Excel, so it's always empty.
@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #51 into master will decrease coverage by 0.38%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
- Coverage   63.49%   63.10%   -0.39%     
==========================================
  Files         100      100              
  Lines        4005     3288     -717     
==========================================
- Hits         2543     2075     -468     
+ Misses       1417     1169     -248     
+ Partials       45       44       -1     
Impacted Files Coverage Δ
internal/number_format/types.go 71.42% <75.00%> (+1.05%) ⬆️
internal/number_format/indexed.go 100.00% <100.00%> (ø)
internal/ml/primitives/gradient_type.go 80.00% <0.00%> (-4.62%) ⬇️
conditional.go 3.44% <0.00%> (-4.25%) ⬇️
internal/color/color.go 81.81% <0.00%> (-3.90%) ⬇️
format/conditional/rule/databar.go 64.58% <0.00%> (-3.84%) ⬇️
filters.go 2.56% <0.00%> (-3.82%) ⬇️
col.go 66.66% <0.00%> (-3.34%) ⬇️
xlsx.go 80.00% <0.00%> (-3.34%) ⬇️
internal/validator/validator.go 89.47% <0.00%> (-3.12%) ⬇️
... and 92 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89ef343...8278b7d. Read the comment docs.

@plandem
Copy link
Owner

plandem commented Jan 12, 2022

I can't approve these changes, since it changes defaults from the official docs for XLSX. I probably will use this PR as a reference when I will have time to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants