-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some public stops/stations are missing in GTFS as they're missing in physical_station table #24
Comments
Actually, this L35246 example illustrates another problem, which probably should be considered when fixing this one. Joined CIF schedule / stop_times entries currently processed by the script for L35246 are:
While actual entries in these tables are:
Note how including that first entry effectively changes service dates! So condition in aforementioned "massive query" that gets schedule/stop times should not have |
Doing a quick query to check for departure stations with no CRS only returns 12 services starting from LRDDEAC which is a depot. Given we understand TB to mean that passengers can get on or off and LRDDEAC is a depot I think we can skip it. I won't add any extra checks for days etc at this point but I will add that extra join.... because you can never have enough joins. |
For example, L35246 (and about ~1.2k other entries, according to grep) appears to have UPMNLT ("Upminster L.T.") station as its origin, with public departure time.
This station is also present in "TIPLOC Eastings and Northings.xlsx.gz" list, and seem to be a real google-able thing.
It's also missing in physical_station mysql table, which is why it doesn't make it into GTFS, but seem to be greppable in CIF MCA file (ttis653.zip data) as a TI (tiploc insert) entry and is parsed to a corresponding entry in tiploc table:
Maybe it'd make sense to add another JOIN to that massive query for CIF schedules and check both tiploc.crs_code and physical_location.crs_code in case one or other is missing?
The text was updated successfully, but these errors were encountered: