dev-v3
#1412
Merged
dev-v3
#1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The type parameter of `THREE.Object3D` is no longer required (used to be `THREE.Object3D<THREE.Event>` - `THREE.UniformsUtils.merge` now has more appropriate typing which breaks the existing code, workarounded with `as any`
Starting from r155, the light unit is set to physically based one by default. We need to multiply the directional light intensity by PI because of this change. See: mrdoob/three.js#26392
also removed an impossible compat code path
Built the MToon shader using NodeMaterial feature I had to add `three/examples/jsm/nodes/Nodes.js` to rollup's `external` config. Is the solution legit? We have a problem on the current `@types/three`, I had to patch-package. Some of them are already addressed as PR on `three-ts-types` repo I applied temporary changes to several example html files, this should be reverted before merge
…ead of local space
`parameters` have `depthWrite = false` when it's transparent, we have to overwrite this
It seems model normal was multiplied by 100 in UniGLTF 1.27, 1.28. Low confidence
also emit a warning if the model contains vertex colors
The outline was too bright when the outlineLightingMix is zero
This prevents opaque / cutout materials to go white
…utlineWidthTexture
…LightingMix factor is 1 it should be multiplied by (1.0 / PI)
outline didn't respect alpha when outlineLightingMixFactor is not 1
outlineWidthMode is not required when it's not outline pass also add comma
…cheKey it's included in cacheKey in either way. See: https://github.com/mrdoob/three.js/blob/r160/examples/jsm/renderers/common/RenderObject.js#L115
We should have the parametric rim result to a temporary variable
WebGPURenderer creates shader variants for each skeleton uuid so we want to unify skeletons as much as possible If there is a superset skeleton, reuse it
This reverts commit 33fc057. boneInverse might be different between skeletons and the new method does not work well with such cases.
The `Type of property 'cache' circularly references itself in mapped type` still persists The error disappears once I bump TypeScript to v5.1.3 or above
revert several examples back to WebGL `three/examples/jsm/*` now referred by `three/addons/*`; see `tsconfig.json` and `rollup.config.js` `RotateUV` doesn't work properly with UV Animation Mask Texture on r162. Spin using a handmade rotation matrix instead
tested using VRMC_materials_mtoon_UV_Animation_Test.vrm
This is an option to decrease initial rendering time when the model has many materials
If you want to use three-vrm on WebGPU, use `MToonNodeMaterialLoaderPlugin` by specifying the loader in the option of `VRMLoaderPlugin`. See the `webgpu-dnd.html` example for details BREAKING: MToonMaterialLoaderPlugin might put materials other than MToonMaterial (namely, MToonNodeMaterial in this case) to `gltf.userData.vrmMToonMaterials`. This shouldn't affect many users since the interface of MToonNodeMaterial is almost identical to MToonMaterial
Co-authored-by: 0b5vr <[email protected]>
Errors can happen before instantiate MToonNodeMaterial
…ward-compatibility fix: seperate nodes entry for backward compatibility
Specify more appropriate Three.js version in peerDependencies
feat: add resetValues to VRMExpressionManager
clarify that the certain code sections are ommitted Add links to the actual working example code The link to three.js build and GLTFLoader was broken, fixed this
… and its option `experimentalSameBoneCounts`
examples: sameBoneCounts -> experimentalSameBoneCounts
fix: restore alpha test workaround
import WebGPU / NodeMaterial stuff from `three/webgpu` See: mrdoob/three.js#28650 Three.js r167 is not released yet! I tested the behavior by using `yarn link` on `three` and `@types/three` importmaps for Three.js in webgpu examples are temporarily replaced to node_modules, please change them back before merging Some codes inside MToonNodeMaterial emit type errors because of recent @types/three changes I'm asking Methuselar96 why the change is made See: three-types/three-ts-types#1023 (comment)
package.json, readme, examples the build is failing
See about the type assertion: three-types/three-ts-types#1123
`indirectDiffuse`, `indirectSpecular` are no longer interface functions, replaced by `indirect` - See: https://github.com/mrdoob/three.js/blob/4cc8fdfa944181c4274c91061574bcf033315bee/src/nodes/functions/PhysicalLightingModel.js#L510 - See: https://github.com/mrdoob/three.js/blob/4cc8fdfa944181c4274c91061574bcf033315bee/src/nodes/lighting/LightsNode.js#L102
BREAKING feature: preparing for Three.js r167
docs: Improve README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the development branch of the next major version.