Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: try moving several utility implementations to a new package @pixiv/three-vrm-utils #1153

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

0b5vr
Copy link
Contributor

@0b5vr 0b5vr commented Jan 6, 2023

Description

Moved several utility implementations to a new package @pixiv/three-vrm-utils.
As the README of the package says, it's mainly intended to be internal utilities.

It's a similar way to how charcoal manages its utility functions.

Also, I found several utility functions that are not referenced anywhere, so I removed them.

Points need review

  • この方針について、どう思いますか?

@0b5vr 0b5vr requested a review from ke456-png January 6, 2023 09:58
@0b5vr 0b5vr self-assigned this Jan 6, 2023
@0b5vr
Copy link
Contributor Author

0b5vr commented Jan 6, 2023

なんでビルド通らないんだ

@0b5vr
Copy link
Contributor Author

0b5vr commented Jan 10, 2023

あーーー、yarn.lockのdiffがないからキャッシュが腐ってるのかな。yarn.lockにダミー行追加してみました

@0b5vr
Copy link
Contributor Author

0b5vr commented Jan 10, 2023

あたり~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant