Reduce node polyfills #3922
Reduce node polyfills #3922
Conversation
| @@ -256,14 +256,6 @@ module.exports = (env, options) => | |||
| ...(isProd(options) || process.env.DEV_REDUX_LOGGER === "false" | |||
| ? { "redux-logger": false } | |||
| : {}), | |||
|
|
|||
| // Enables static analysis and removal of dead code | |||
| "webext-detect-page": path.resolve( | |||
There was a problem hiding this comment.
This doesn't save much at the moment, dropping
| ), | ||
|
|
||
| // Lighter jQuery version | ||
| jquery: "jquery/dist/jquery.slim.min.js", |
There was a problem hiding this comment.
Moved to the shared config
| REDUX_DEV_TOOLS: !isProd(options), | ||
| NPM_PACKAGE_VERSION: process.env.npm_package_version, | ||
| ENVIRONMENT: process.env.ENVIRONMENT ?? options.mode, | ||
| ENVIRONMENT: options.mode, |
There was a problem hiding this comment.
EnvironmentPlugin already uses process.env natively. As the comment suggests, these are just fallback values
webpack.sharedConfig.js
Outdated
| }, | ||
| extensions: [".ts", ".tsx", ".jsx", ".js"], | ||
| fallback: { | ||
| http: false, | ||
| https: false, |
There was a problem hiding this comment.
I presume we don't use external references in our schemas. If we do, I'll have to restore these 2 polyfills in NodePolyfillPlugin until:
There was a problem hiding this comment.
Do the schema URL references count? I don't think they are being actually requested anywhere.
We also have "external" references in blocks definitions (some of them like pipeline don't work though):
There was a problem hiding this comment.
I think that's exactly it, $ref will be "resolved", in this case by first fetching the external schema (I presume): https://github.com/APIDevTools/json-schema-ref-parser#the-solution
I restored the http/https polyfills for now, hopefully the maintainers will use fetch in the future.
Codecov Report
@@ Coverage Diff @@
## main #3922 +/- ##
=======================================
Coverage 46.71% 46.71%
=======================================
Files 858 858
Lines 25446 25446
Branches 5313 5313
=======================================
Hits 11887 11887
Misses 12622 12622
Partials 937 937 Continue to review full report at Codecov.
|
webpack.sharedConfig.js
Outdated
| }, | ||
| extensions: [".ts", ".tsx", ".jsx", ".js"], | ||
| fallback: { | ||
| http: false, | ||
| https: false, |
There was a problem hiding this comment.
Do the schema URL references count? I don't think they are being actually requested anywhere.
We also have "external" references in blocks definitions (some of them like pipeline don't work though):
This PR just addresses some minor issues I encountered while debugging #3915