Podfile excluding headers

[parrots]

Zipzap has been changed to include a list of public headers in the podspec and the only one listed is zipzap.h. Unfortunately this means that the headers that one references aren't exported. Removing the public_headers line fixes the issue, but I'd assume adding the list of all headers an external project should be able to use would fix this too.

Steps to reproduce:

• Create a new project in Xcode
• Add a Podfile with zipzap listed as the only pod
• Run pod install
• Add the import for zipzap.h to any class in the project
• Build
• Observe error in zipzap.h: "ZZArchive.h file not found"

[laiso]

I am getting the same problem too.

Also, show the build failures at @throw in my code.
I think it's need a rewrite of podspec.

https://github.com/pixelglow/zipzap/blob/master/zipzap.podspec.json

 "public_header_files": "zipzap/zipzap.h",
// ...
"OTHER_CPLUSPLUSFLAGS": "-fno-exceptions"

[pixelglow]

@parrots @laiso I'll look into the podspec issue.

@laiso you also have issues with @throw? The library does not support exceptions passing through the code, you would have to use the usual "return nil/NO and set error" paradigm that Cocoa itself uses instead of exceptions. If your callbacks don't let exceptions escape, that should be fine. Please raise a new issue if you can isolate a minimal bad build.

[laiso]

@pixelglow You got that right. I'm considering rewrite a code to an error object handling.

[chrisze]

@pixelglow : I'm having the same problems with exceptions and headers in our project as well; the latest zipzap pod disables objective-c exceptions globally, so our app no longer compiles (we have 3rd party code which does use exceptions and it's not feasible for us to re-write it).

The easiest way to reproduce the problem is to create a new project with objective-c exceptions enabled (the default), add some dummy @try @catch block, and add zipzap to the podfile.

Thanks for the great library. It's pleasure to use.

[chrisze]

@pixelglow : do you know of a workaround for these two problems?

[zygoat]

d2d8454 seems to solve the header include problem, but not the project-wide disabling of Obj-C exceptions. Like @chrisze we have a few @Try / @catches elsewhere in our project and it's not feasible to immediately re-write a bunch of other code simply to satisfy this one unrelated dependency.

[zygoat]

Actually, my complaint may have been premature. Looking at our build settings, it appears we had been relying on the top-level default of GCC_ENABLE_OBJC_EXCEPTIONS = YES (which was then overridden to be NO in Pods.xcconfig due to zipzap). However, it was not explicitly set at the project or target level. Doing so there seems to resolve the issue.

[laiso]

@chrisze You can manually set the GCC_ENABLE_OBJC_EXCEPTIONS.

[laiso]

I seem somewhat obscure the project-wide disabling of Obj-C exceptions, me too.

[chrisze]

Thanks @laiso. Yes, this does solve the problem. The only remaining issue is that those settings get reverted back when your run pod install again, but that's merely a nuisance.