Support for Devuan #263
Support for Devuan #263
Conversation
- To simplify further additions to PLAT or OSCN, use the case command for checking - Treat Devuan as Debian - Add /sbin:/usr/sbin to PATH before calling ifconfig - Ensure net-tools is installed so we have ifconfig
|
I tested it on Debian, Devuan, Ubuntu 14.04 as VMs in VirtualBox. And have tried it on I have not verified it on Raspbian, but the code for Devuan should flow thru the same path.
I did find a bug when running as root on Devuan on a Pi3, I’ll have to fix that first.
… On Jun 4, 2017, at 4:46 PM, redfast00 ***@***.***> wrote:
@redfast00 approved this pull request.
Thanks a lot! Looks good to me. Have you tested this both on Devuan and on Raspbian?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#263 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA7tHgMqmkQfPL1jBxROxpWf8G49Wlbqks5sAxehgaJpZM4Nveth>.
|
|
I hadn't tried running this as root. Let me do some more testing. |
|
I'm going to close this request, fix the errors and create a new one. |
|
You should be able to just commit into your repo, and it will automatically add the commits to the PR. (atleast that's how it works for me). Do you want to reopen this PR? |
|
This is my first pull request. If it works ok that way, please reopen. Once I finish testing and committing to my test branch, I'll add a comment saying it is ready.
Thanks.
|
|
Thank you for contributing to open source software! It's a really great way to give back. If you plan on doing some more PR or even making helpful issues, definitely check out codecuriosity.com. They give you gift cards for contributing to open source software. Please feel free to ask any questions if you have trouble using Git or GitHub. |
|
I will reopen this when all testing is done. |
Changes: - Document that Devuan is supported. - Use special PLAT name, Raspvuan for Pi version - Use service command for any *vuan PLAT, systemd is no on any Devuan. - add net-tools to PIVPN_DEPS
|
OK. |
|
Thank you! |
| fi | ||
|
|
||
| case ${PLAT} in | ||
| Ubuntu|Raspbian|Debian|Devuan) |
There was a problem hiding this comment.
hey @redfast00 , why only here is Ubuntu|Raspbian|Debian|Devuan and other places is Ubuntu|Debian|Devuan
why don't you do a global var to avoid repeating it?
There was a problem hiding this comment.
@fernandog because there are different actions to be taken depending on distro!
For example, Static IP address is not handled by PiVPN if you are using Ubuntu || Debian because it can be a cloud instance with its own address.
so makes total sense to have different conditions for different distros.
I advise you to better read the code, so you can better understand what I am saying
I just downloaded and installed Devuan (1.0) on my PI3. I wanted to test out pivpn on it and with these mods, it will install and work.
Just thought I'd pass it on as a pull request.
Thanks.
Changes:
To simplify further additions to PLAT or OSCN, use
the case command for checking
Treat Devuan as Debian
Add /sbin:/usr/sbin to PATH before calling ifconfig
Ensure net-tools is installed so we have ifconfig