Clearly and consistently indicate that a user selects a list item with the space bar. #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine to me, thanks for the PR :D waiting for @0-kaladin to merge. |
|
Ping @0-kaladin |
|
Will look. Thx
…On Tue, May 2, 2017, 16:40 redfast00 ***@***.***> wrote:
Ping @0-kaladin <https://github.com/0-kaladin>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#243 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADc_mKE4_vL-CWSoXGL4dQ1VdviW-bmKks5r15TUgaJpZM4M_Kj9>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the installation procedure, a user is presented multiple times with a list of items to choose from. These are selected by pressing the space bar. However, this is only indicated textually at the step where the user selects which interface to use. This pull request adds this text to every item selection step. Presumably fixes issue #232 .