Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install.sh to support wider Ubuntu detection #1723

Merged
merged 3 commits into from
May 13, 2023

Conversation

thadguidry
Copy link
Contributor

@thadguidry thadguidry commented May 7, 2023

Add Ubuntu Lunar (Lobster) which is now available on cloud providers.
Tested with Lunar Lobster 23.04.

Add Ubuntu Kinetic and Lunar (Lobster)
@orazioedoardo
Copy link
Member

It's good to know that the script works but I don't think we want to add non LTS releases. Doing so would mean more commitment to test those releases. The user can still install by clicking through a warning.

@thadguidry thadguidry closed this May 11, 2023
@coolapso
Copy link
Member

coolapso commented May 12, 2023

why was this closed? its not yet available on the ci environment tho.

if you want this to go through, please remove kinetic and leave only lunar.

also please update the commit message and make sure to follow the guidelines at: https://github.com/pivpn/pivpn#pull-requests

@thadguidry thadguidry reopened this May 13, 2023
@thadguidry thadguidry changed the base branch from master to test May 13, 2023 02:18
@thadguidry
Copy link
Contributor Author

thadguidry commented May 13, 2023

@4s3ti Thanks for guidance. However I am finding it IMPOSSIBLE to amend previous commit messages using command line, VSCode GitLens was tried. Git does not like me rewriting history ;-). Since this will likely be squashed, can you assist? I am not even sure what categories this applies to for your CI or documentation. Is it a feature? Is this change something else? I leave it to your team to best decide. Your contributing guide is Amazing! But not for the faint of heart by anyone outside of your team. I sincerely wish all of you the best and thanks for giving the world a great VPN server with terrific documentation and an easy installer script!

@coolapso coolapso merged commit 241d7c4 into pivpn:test May 13, 2023
1 check passed
@coolapso
Copy link
Member

🎉 This PR is included in version 4.3.0-test.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@coolapso
Copy link
Member

Thank you for your contribution.
I will add the CI tests as soon as travisci has it available.

about git ...
I only use git with CLI so i don't know hpw you do it in other tools.

in this partircular case i would use git reset <commitID> to go to back to that particular commit without losing any changes, and then commit again with the correct message and force push.

@thadguidry
Copy link
Contributor Author

@4s3ti Ah, not an amend actually then: git commit --amend
, but instead a git reset.
When you said "update the commit message" that implied to me to amend. Since I had already pushed, the --amend of course was impossible, so only a git reset (undo a commit) could pull me out of the weeds. Gotcha.

@thadguidry thadguidry deleted the patch-1 branch May 13, 2023 11:31
@coolapso
Copy link
Member

🎉 This PR is included in version 4.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants