Show correct information and fix error caused by dash on printf in clientStat.sh

[astroganga]

At line 53 of clientStat.sh there is a printf that starts with minus sign

53 printf "- %s\n" "${array[9]}"

When pivpn clients command is executed the minus sign is interpreted as an option and the script fails by not printing the connection time.

I fixed the issue adding -- before the format string to disarm the minus sign.

53 printf -- "- %s\n" "${array[9]}"

Hope this helps.
Thanks
Bye.

[coolapso]

hi, ty for the PR .. please read and change the target branch: https://github.com/pivpn/pivpn#pull-requests

[coolapso]

Once again thanks a lot for your PR, after a proper review, please check my comments regarding the code itself.

Also please amend your commit message to be according to the commit rules.

In this situation the way I would do it is:

• git reset HEAD~1
• make the suggested code changes
• git commit

The header of the commit should be: fix(scripts): fix clientstat.sh
The commit body should be (for example): show correct information and fix error caused by dash on printf

should look something like:

fix(scripts): clientstat.sh

show correct information and fix error caused by dash on printf

• git push origin master --force

Please note the suggestion is just one way of doing it, feel free to use any method that feels better for you.

[coolapso]

hmm crap ... don't think changing from stable to test will change anything, it seems the openvpn-status.log saves data based on some regional settings which affects the position of the array where the data ends up =/ this kind of "parsing" is always messy =/

then I say it might be better to just remove the dash, and some day if i have the time I might try to find a better way to parse the log file.

[astroganga]

Ok. If you agree I will adjust the fix removing the dash on line 53:

printf "%s\n" "${array[9]}"

without touching array order. If some are empty I don't think will be an issue and at the same time we will not lose information on other regional settings.

I will do it tomorrow as it is too late for me now.
Thanks

[coolapso]

yeah its fine, just remove the dash.

On my case (using aws ec2 instnace), it was actually returning meaningless data.

[coolapso]

Done, thanks a lot :D

[coolapso]

🎉 This PR is included in version 4.1.6-test.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[coolapso]

🎉 This PR is included in version 4.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀