Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1556 #1557

Merged
merged 1 commit into from
Jun 25, 2022
Merged

Fixes #1556 #1557

merged 1 commit into from
Jun 25, 2022

Conversation

megakoresh
Copy link
Contributor

@megakoresh megakoresh commented Jun 25, 2022

Fixes #1556

@coolapso
Copy link
Member

Great catch, thanks a lot for your PR.
Please change the branch to test branch.

@megakoresh megakoresh changed the base branch from master to test June 25, 2022 09:40
@coolapso
Copy link
Member

It just bugs me how is that been unnoticed for quite some time and not even caught on the tests.
baybe there are some cases where the command takes a bit longer to run and the CD after happens too fast? 🤷 either way its a rly good catch .

Thanks for changing the branch. Merging to test.

@coolapso coolapso merged commit 718d3df into pivpn:test Jun 25, 2022
@orazioedoardo
Copy link
Member

Very sneaky bug, thank you!

@megakoresh megakoresh deleted the patch-1 branch June 25, 2022 11:21
@coolapso
Copy link
Member

I know why it was actually not being noticed on the tests ...

the CI Environment already has git installed therefore it doesn't fail on that command.

@megakoresh
Copy link
Contributor Author

megakoresh commented Jun 25, 2022

I know why it was actually not being noticed on the tests ...

the CI Environment already has git installed therefore it doesn't fail on that command.

That is strange because this command isn't installing git, it just clones the repo. And on the ubuntu image I also had git installed from the beginning.

My suspicion is that on CI this clone command runs so quickly that by the time the next cd command runs, the git clone already completes. Thats why it hasn't noticed this problem.

@coolapso
Copy link
Member

🎉 This PR is included in version 4.1.0-test.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@coolapso
Copy link
Member

🎉 This PR is included in version 4.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in installer causes install.sh: line 1109: cd: /usr/local/src/pivpn: No such file or directory
3 participants