Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for builtin WireGuard module #1551

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Add support for builtin WireGuard module #1551

merged 1 commit into from
Jun 10, 2022

Conversation

MichaIng
Copy link
Contributor

in which case there is no dedicated file in /lib/modules. A rare case but possible.

Additionally the recursive globbing has been replaced by dpkg-query's internal recursive asterisk matching, which performs better/faster. This does now also match on "wireguard.kosomething", but I think "wireguard" is specific enough and dots in kernel modules names uncommon, to no be an issue.

in which case there is no dedicated file in /lib/modules. A rare case but possible.

Additionally the recursive globbing has been replaced by dpkg-query's internal recursive asterisk matching, which performs better/faster. This does now also match on "wireguard.kosomething", but I think "wireguard" is specific enough and dots in kernel modules names uncommon, to no be an issue.

Signed-off-by: MichaIng <[email protected]>
@MichaIng
Copy link
Contributor Author

MichaIng commented Jun 10, 2022

I didn't do a test install, so would be good to so, here or on test branch, just in case I made a typo or something 😅.

The check/condition itself however works pretty well on DietPi since a while.

@coolapso
Copy link
Member

well hopefully CI pipelines will catch if there is any typo :p

@MichaIng
Copy link
Contributor Author

Ah right, it includes install tests already 👍. Now I have another suggestion: Add Ubuntu Jammy to the test matrix? 🙂

@coolapso
Copy link
Member

Merging.

unfortunately 22.04 is not yet available on TravisCI: https://docs.travis-ci.com/user/reference/linux/ :(

yet to find a (free) CI environment that supports all PiVPN needs, kinda tricky.

@coolapso coolapso merged commit e52a2c4 into pivpn:test Jun 10, 2022
@MichaIng MichaIng deleted the patch-1 branch June 10, 2022 13:24
@MichaIng
Copy link
Contributor Author

GitHub actions, although it does not support Ubuntu Xenial anymore.

@coolapso
Copy link
Member

been growing quite fund of GH Actions to be honest! might give it a shot when i have some more time.

@MichaIng
Copy link
Contributor Author

Jep, quite valuable/mighty. But an argument against it might be to not depend too much on a single platform owned by Microsoft.

@coolapso
Copy link
Member

well that is true, but I stopped worrying to much about those things. also don't think we (pivpn) are going anywhere else anyway unless something really major happens with GitHub.

@MichaIng
Copy link
Contributor Author

Jep, same here, until now I couldn't find any real reason to worry or switch, no MS service integration and MS +GitHub account merge or such things, people were worrying about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants