Fix errors on logging configuration #1362
Conversation
rsyslog and/or logrotate may not be installed on the system, in which case creating the configurations may fail. As rsyslog and logrotate may be installed later on, it makes sense to pre-create those directories so that then OpenVPN logs are handled as expected. Also, if the rsyslog service is not installed or not active, it should not and does not need to be restarted. Since there is not `-e` flag, ` || true` has not effect, but also, when using that flag it makes sense to exit if for some reason the running service couldn't be restarted, which may then be caused by the added configuration. Signed-off-by: MichaIng <[email protected]>
|
LGTM, any open issue this is related to? |
|
Here is a report on our repo: MichaIng/DietPi#4825 (comment) |
|
can you confirm if this is related too? #1360 |
|
Merging regardless, thanks a lot once again! |
|
Yes exactly, though I didn't replicate yet. Looks like a bug in the packages's maintainer script or perl functions, probably related to a debconf call, not sure yet 🤔. |
|
I want to add here, problem with install script for pivpn-WireGuard (not in Dietpi, I run it from website), I download clean Dietpi image for both (Raspberry pi 4b and zero w in same time, both 32 bit and in clean system I install with pivpn script WireGuard on both, but zero works without problem. No problem with debconf, don't need manually install iptables-persistent or unattended-updates. Buster, same day download, only different raspberry. Zero without problems, pi4 have problem in my report here |
|
this is becoming too much to handle with all different Boards/Os ... think making a docker version might become very urgent soon, lets hope i find time to work on it soon... |
|
That is an issue with debconf and I guess either/or when STDIN and/or STDOUT are redirected, however not related to this PR at all. Check out discussion at the issue you linked to investigate what happens there. |
rsyslog and/or logrotate may not be installed on the system, in which case creating the configurations may fail. As rsyslog and logrotate may be installed later on, it makes sense to pre-create those directories so that then OpenVPN logs are handled as expected.
Also, if the rsyslog service is not installed or not active, it should not and does not need to be restarted. Since there is not
-eflag,|| truehas not effect, but also, when using that flag it makes sense to exit if for some reason the running service couldn't be restarted, which may then be caused by the added configuration.