-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support setupVars for pivpnNET, subnetClass and ALLOWED_IPS via unattended setup #1279
Support setupVars for pivpnNET, subnetClass and ALLOWED_IPS via unattended setup #1279
Conversation
I am not completely sure that it's early enough to define
Update: According to travis it seems fine. |
Can't test the pull request(s) however I can tell that these lines are used to set the static IP settings when using unattended on Raspbian. |
What does "Can't text the..." mean? Are those vars required when setting up wireguard VPN or not? I went through the code and checked all references. They only seem to be required in connection with OpenVPN. So not needed with Wireguard. |
Test, actually.
Look at this function. |
Thanks. I checked this function before and could not see why those values should be required by wireguard. The genegrated setupVars.conf file does not contain them either. If I understand the I can remove the commit regarding those vars. But I'd like to keep the example files correct if possible. If I understand those vars correctly they allow to specify the local subnet, including mask and the default gw that the VPN server should use itself? DHCP is not required for Wireguard at all, that is why I am asking.
|
Because you tested the script on Debian, it does on Raspian.
Yes Switch target branch to test please. |
So if one should use those vars we can leave them in the example file. Maybe we should extend the documentation and explain what those vars are for.
Done |
How do we get this merged now? In my test installations it was working fine. |
Please resolve the conflicts on your base branch please, seems to be related with the merge of one of your merge requests. |
Apparently it was caused by the other merge request I pushed. Will check this soon and get it fixed. |
Sorry for the delay. Was busy and then forgot about it. Hope it's fine now and can get merged soon. |
Support setupVars for
pivpnNET
,subnetClass
andALLOWED_IPS
via unattended setup.pivpnNET
andsubnetClass
pivpnNET
,subnetClass
andALLOWED_IPS
Fix part of #1273