Improved dual VPN uninstallation, remove duplicate code/script #1060
Conversation
- Allow using 'pivpn vpn -u' to directly uninstall VPN 'vpn'
- Also allow using 'pivpn -u' with two VPNs (will present a dialog).
- During uninstall, ask which VPN to remove only if there are two VPNs
- PiVPN git repo will be downloaded to '/usr/local/src/pivpn'. All scripts
in /opt/pivpn, the main pivpn script and the bash completion file,
are now just symbolic links. Resolves issue pivpn#695.
- Remove unused call to updateWireGuard().
- /usr/local/src, when cloning the git repository
- /opt (this one was already taken into account but I had accidentally
removed the mkdir command in the previous commit).
|
Yes, looking. At the moment won't install on Buster, going for clean OS again. |
|
Since this pull request adds something to what you started, I wanted to know if you approve the changes or you had something different in mind. |
|
Happy with it, just trying to test it. Go ahead. |
|
Was it intended that the update functionality is "temporarily disabled" now for 4 years? |
|
It was disabled since updates didn’t really work AFAIK nor were intended to: https://github.com/pivpn/pivpn/wiki/Upgrading. “Temporarily” because I had the idea to eventually bring it back. |
|
I see. Though I do not really understand how updating the PiVPN shell scripts can break existing client certificates/configs. And I see no point to revoke old and generate new ones, only because of updated PiVPN scripts? Using The question how to get to the last PiVPN release just came up while talking about the end of PiVPN. Very sad, it was very popular among the software options of our distro, more popular than our plain OpenVPN and WireGuard server implementations. Looks like we need to add a little client config/cert management CLI or whiptail UI to cover some of the functionality PiVPN greatly provided. Many thanks for the time and efforts you put into this project all those years 🙂! I understand that you cannot hand it over to someone you do not know, especially since VPN access is a very sensitive thing. But I still hope someone will actively maintain a fork which gains enough trust and popularity to be a worthy successor, before the existing code if this repo starts to have problems. |
Probably not existing but there have been cases with WireGuard I think, where the new version of the scripts would create configs with different format, or expecting shell variables with different name, in different files, etc.
Yeah, actually I don’t exactly agree with PiVPN being declared unmaintained (not my decision though I’m not owner of the organization). Even though there have been few changes lately as I said in the discussion it’s still very popular, perhaps over the years it became the go-to solution for VPN on Raspberry so people naturally followed. I might push some commits to add support for future versions of distros if the repo is not archived but not sure if it makes sense at this point. |
Possible. For such cases I like to add some post update dialogues or config/setup migration steps, but of course it is another maintenance effort and possible source of bugs, as stated in the wiki.
Probably @4s3ti agrees to make you (as well) owner if the orga? There can be multiple ones. I mean in raw line change numbers you are the number 1 contributor of this project. I just found #1829, will add some words there. |
@orazioedoardo I believe you should be given the opportunity to become full maintainer for This closure is very sudden and unfortunate. |
in /opt/pivpn, the main pivpn script and the bash completion file,
are now just symbolic links. Resolves issue duplicated code/scripts in pivpn installation - why ? #695.
@shelleycat485 what to you think?