feat(dropdown): Dropdown passes through attributes #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(actually @gpleiss): needs tests for |
abea3ba
to
6e61f75
Compare
|
Added DropdownItem tests |
| @@ -159,7 +159,7 @@ var Dropdown = require('pui-react-dropdowns').Dropdown; | |||
| This is the basic bootstrap dropdown: | |||
|
|
|||
| ```react_example_table | |||
| <UI.Dropdown title='DropDown'> | |||
| <UI.Dropdown title='DropDown' buttonClassName="my-btn-class"> | |||
There was a problem hiding this comment.
Two problems with this documentation
-
We should explain that buttonClassName is optional. It's confusing in this example - it looks like you need to include the buttonClassName property in order for the component to work.
-
Instead of a made-up class name, we should show an example with a className that creates an obvious appearance difference in the Dropdown - like
btn-large(or whatever it is).
There was a problem hiding this comment.
Turns out we have an example of using buttonClassName lower in the documentation. So we should just remove this hanging buttonClassName, and then this should be ready for merge.
Dropdown passes through className, id and style. Dropdown merges buttonClassName when provided. DropdownItem passes through className, id and style. Updates documentation to include buttonClassName. [Finishes #98913274]
6e61f75
to
87b40f7
Compare
|
Ready for merge 👍 |
buttonClassName is merged and applied to the button [Finishes #98913274]
stubbornella
added a commit
that referenced
this pull request
Jul 22, 2015
feat(dropdown): Dropdown passes through attributes
aks-
pushed a commit
to aks-/pivotal-ui
that referenced
this pull request
Oct 25, 2016
…placeholder fix(header): replace "on-site" with "enterprise" in search input placeholder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropdown passes through className and style.
Dropdown merges buttonClassName when provided.
Updates documentation to include buttonClassName.
[Finishes #98913274]