Remove therubyracer as a dependency #133
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
therubyracer
dependency requires quite a lot of configuring to get setup on OS X Catalina, as well as requiring a very out of date version ofV8
to be installed.Looking through the commits that included it as a dependency, it looks though it was originally brought in to support
gocd
, which I'm uncertain is actually a requirement anymore.Looking at the actual built apps bookbinder creates, I'm not certain why it is a dependency of the created rack app, either, as I'm not even sure how it would be invoked since
sprockets
orexecjs
aren't included, nor are there any direct references to it.For these reasons, I've removed the dependency outright. Potentially it could be replaced with
mini_racer
, which seems to build more easily on OS X, but again, I'm not sure any ruby JS runtime is required.