Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove therubyracer as a dependency #133

Merged
merged 3 commits into from
Jan 20, 2022
Merged

Conversation

butzopower
Copy link

Currently therubyracer dependency requires quite a lot of configuring to get setup on OS X Catalina, as well as requiring a very out of date version of V8 to be installed.

Looking through the commits that included it as a dependency, it looks though it was originally brought in to support gocd, which I'm uncertain is actually a requirement anymore.

Looking at the actual built apps bookbinder creates, I'm not certain why it is a dependency of the created rack app, either, as I'm not even sure how it would be invoked since sprockets or execjs aren't included, nor are there any direct references to it.

For these reasons, I've removed the dependency outright. Potentially it could be replaced with mini_racer, which seems to build more easily on OS X, but again, I'm not sure any ruby JS runtime is required.

@cf-gitbot
Copy link
Member

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@rhoughton-pivot
Copy link

Hey, can we move forward on this? I'm unable to run bookbinder on my mac at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants