Fix async let binding expansion #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6321f5b
to
e693308
Compare
Previously, the `async` macro would attempt to treat a non-symbol value for a binding
in a `let` as a function call and so the following would happen:
```
(h/async
(let [result (await (js/Promise.resolve "value"))]
...))
;; Compiles into...
var xyz = Promise.resolve("value").call()
```
This commit fixes this so that `await`-ed `let` bindings are properly handled.
- Remove macroexpansion from tests
With the correct let binding handling, macroexpansion doesn't work because the resulting
binding names are random (something like v_51003, p_40892), which can't really be equated.
Since we can test the `async` macro directly we can just remove the macroexpansion tests
completely.
Fixes #31.
Previously, if you had a let binding that depended on a previous binding, it wouldn't work because the `async` macro would expand into a `js/Promise.all` call with the values, and the symbols as the bindings for the next `.then` call. This meant that if one of the values in `Promise.all` depended on a previous binding symbol, it wouldn't be able to resolve it. This commit fixes this by generating a new `let` call for each pair if any of the binding pairs has `await`. Fixes #30.
In the future, it might be nice to bring this back, but I would like to find a better way to handle it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
letbinding usage inside ofasync, so that you can properly useawaitforletbindings.