Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding another check to _check_corpus_sanity for compressed files, adding test #3258

Merged
merged 3 commits into from
Dec 4, 2021

Conversation

dchaplinsky
Copy link
Contributor

Closes #3246

gensim/models/word2vec.py Outdated Show resolved Hide resolved
gensim/models/word2vec.py Outdated Show resolved Hide resolved
Co-authored-by: Radim Řehůřek <[email protected]>
@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #3258 (3be4190) into develop (e51288c) will increase coverage by 0.44%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3258      +/-   ##
===========================================
+ Coverage    78.88%   79.32%   +0.44%     
===========================================
  Files           68       68              
  Lines        11772    11777       +5     
===========================================
+ Hits          9286     9342      +56     
+ Misses        2486     2435      -51     
Impacted Files Coverage Δ
gensim/models/word2vec.py 89.70% <80.00%> (-0.07%) ⬇️
gensim/utils.py 71.54% <0.00%> (+0.48%) ⬆️
gensim/corpora/wikicorpus.py 93.75% <0.00%> (+11.53%) ⬆️
gensim/scripts/segment_wiki.py 92.37% <0.00%> (+21.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e51288c...3be4190. Read the comment docs.

@dchaplinsky
Copy link
Contributor Author

Hello @piskvorky
Anything else needs to be done on this one?

@piskvorky
Copy link
Owner

piskvorky commented Nov 1, 2021

Looks good to me, thanks! Now let's wait for @mpenkov 's review and merge, thanks for your patience.

@mpenkov mpenkov merged commit a9817ae into piskvorky:develop Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partial support of compressed corpora in FastText model
3 participants