2.2.0 Release #221
Merged
2.2.0 Release #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed isIOS references in favor of isMobileDevice. Removed scrollfix for iOS, as it is no longer needed as of iOS13. iOS 12 and lower have ~5-7% marketshare and shrinking fast.
Expanded detection where needed (Safari desktop vs iPad), simplified where possible, and added more object checks (e.g. navigator.mimeTypes) for safely working in nodejs environment
All modern browser support console, as does nodejs. Removed safety check for console and deleted custom log function
Switched to pure DOM methods in place of innerHTML. (Left innerHTML for fallback string option)
Replaced custom addClass function with standard classList (supported in IE11 and all modern browsers)
Consolidated two similar functions into one.
Standardized on double quotes
Missed a spot
Switching from typeof checks to direct comparisons. undefined cannot be redefined in modern browsers and is safer to use than it used to be. It's also more concise. Also replaced ternary statements with || where applicable to make code more concise.
Resolves #200 . Option `omitInlineStyles = true` will instruct PDFObject to embed the PDF without using inline styles. **The embed will appear broken if the developer does not provide appropriate styles via their own CSS.**
set `suppressConsole = true` to prevent PDFObject from writing error messages to the console
Mostly just code cleanup
AKA dragging PDFObject to ECMAScript 2015 kicking and screaming by using `let` and multiple declarations per function instead of the Corckford one var per func standard.
Set `forceIframe = true` to force PDFObject to use iframes for the embed. Has no effect on `forcePDFJS` option.
Old embed method used innerHTML, which would clear out any prior content. Now that we're using DOM methods, we need to add an extra check to ensure the node is empty instead of simply appending new content to existing content
Old check used typeof which was verbose but safe. New method uses direct comparison to `undefined` but this requires var being checked to be in global scope (in window) otherwise will throw an error
Corrected ID assignment (DOM instead of string), and added a check for existence of ID before trying to assign to DOM element (avoid assigning empty string).
1. Don't set styles directly 2. isIE is no longer a function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
omitInlineStylestotrue. This helps developers who use strict environments where inline styles are not allowed. Note you will be responsible for applying proper styling via your own CSS.suppressConsoletotrue. PDFObject current places error messages in the console if the PDF can't be embedded for some reason. This optioon allows you to mute those alerts.<embed>) by settingforceIframetotrue.letin lieu ofvar,el.classList.add()in place ofel.className = 'foo', andmyvar === undefinedin place oftypeof myvar === "undefined". Implemented aletdeclaration before each variable instead of the Crockford practice of onevarper function.innerHTML. Replaced with standard DOM methods. This helps alleviate unforeseen issues with file names. Only exception is insertion of fallback content, which is passed as a string viainnerHTML.