Removed DeepReadonly limitation on non-function keys to fix optional … #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…keys marked as required
1290862
to
ded85f7
Compare
|
Thanks for finding the workaround here, @piotrwitek. I think this change makes sense! I am curious though: can you explain what was broken when changing |
|
Behaviour of the particular type was broken, it was supposed to be narrowed by |
|
Thnx for a nice update! I see that is has been merged with master, when will it see the light of day? |
|
I'll try to release a new package today/tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed DeepReadonly limitation on non-function keys to fix optional keys marked as required