Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added "UnionKeys" type #193

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Added "UnionKeys" type #193

merged 1 commit into from
Feb 13, 2024

Conversation

filipomar
Copy link
Contributor

@filipomar filipomar commented Feb 10, 2024 •
edited
Loading

Description

Added UnionKeys type as discussed on the issue linked below

Related issues:

Checklist

  • I have read CONTRIBUTING.md
  • I have linked all related issues above
  • I have rebased my branch

For bugfixes:

  • I have added at least one unit test to confirm the bug have been fixed
  • I have checked and updated TOC and API Docs when necessary

For new features:

  • I have added entry in TOC and API Docs
  • I have added a short example in API Docs to demonstrate new usage
  • I have added type unit tests with dts-jest

@filipomar filipomar mentioned this pull request Feb 10, 2024
Closed
piotrwitek
piotrwitek approved these changes Feb 13, 2024
View reviewed changes
Copy link
Owner

@piotrwitek piotrwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you @filipomar

@piotrwitek piotrwitek merged commit 2491e46 into piotrwitek:master Feb 13, 2024
@filipomar
Copy link
Contributor Author

Btw is there an timeline to release this on... what I assume is 3.12.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrwitek piotrwitek piotrwitek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow for a AllUnionKeys
2 participants
@filipomar @piotrwitek