Add Mutable type
#111
Merged
Add Mutable type
#111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosentmatter
force-pushed
the
feature/27-add-mutable-type
branch
from
fc5234e
to
9ecdb25
Compare
|
Should this be called |
|
Let's go with mutable, adding an alias for mutable keys. I would also clean up the main documentation API leaving only the suggested apis on the list while leaving aliases only in the description
…On Mon, Oct 21, 2019, 9:01 AM Kevin Lau ***@***.***> wrote:
Should this be called Mutable or Writable? We have another type called
WritableKeys<T>
<https://github.com/piotrwitek/utility-types#writablekeyst>. TypeScript
uses the word Mutable in their docs
<https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-8.html#example-5>
though.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#111?email_source=notifications&email_token=AAFUOAZVRHSY4SEBOZYBOT3QPVHTXA5CNFSM4JCY445KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBZIUNY#issuecomment-544377399>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFUOA4CWFNYYG7A7EYBBXLQPVHTXANCNFSM4JCY445A>
.
|
dosentmatter
added a commit
to dosentmatter/utility-types
that referenced
this pull request
Oct 22, 2019
Keep `WritableKeys<T>` as an alias to `MutableKeys<T>`. Issue: piotrwitek#111
|
@piotrwitek, thanks for the feedback. I renamed |
piotrwitek
approved these changes
Oct 22, 2019
|
@dosentmatter could you please rebase your PRs branch? I would like to merge and it has conflicts currently. |
Resolves: piotrwitek#27
Keep `WritableKeys<T>` as an alias to `MutableKeys<T>`. Issue: piotrwitek#111
dosentmatter
force-pushed
the
feature/27-add-mutable-type
branch
from
719844a
to
57305dd
Compare
|
@piotrwitek, I rebased this branch onto the latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
Mutabletype.Related issues:
Checklist
For new features:
dts-jestIssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor