Bugfix/documentation typo fixes #110
Conversation
|
|
||
| --- | ||
|
|
||
| ## Flow's Utility Types | ||
|
|
||
| ### `$Keys<T>` | ||
|
|
||
| get the union type of all the keys in an object type `T` |
There was a problem hiding this comment.
I would like to get back all of these trailing whitespaces in descriptions because it provided a nice line-break to keep the link on a separate line.
Below are more of them, please take care of them too.
There was a problem hiding this comment.
What do you think about using inline HTML <br> tag instead? I think it's a bit more readable and searchable. Also, if we go and do a find&replace of trailing whitespace (or add it to the linter/prettier/editorconfig), we don't have to worry about messing up the double trailing whitespace.
If you prefer the double trailing whitespace in markdown. I can revert it.
There was a problem hiding this comment.
Great idea with <br />, I love it! 👍
There was a problem hiding this comment.
I added back the line breaks with <br>.
Also added alias for Writable<T>. Forgot to do it in #27.
There was a problem hiding this comment.
Alias looks good, although it's not re-exported from index.ts for public access.
There was a problem hiding this comment.
Whoops, my bad. I re-exported it in latest commit now.
dosentmatter
force-pushed
the
bugfix/documentation-typo-fixes
branch
from
dc3f4a1
to
507fec6
Compare
`Brand` is not a Flow utility type.
@piotrwitek commented for `Optional` -> `Partial`, it doesn't cost anything to add an alias and a mention in docs. See: piotrwitek#112 (comment) Similarly, the same can be said for `Writable` -> `Mutable`. We already have `WritableKeys<T>` -> `MutableKeys<T>` alias.
dosentmatter
force-pushed
the
bugfix/documentation-typo-fixes
branch
from
127b706
to
aae2a03
Compare
|
Looks great, thanks for the contribution! 🎉 |
Description
Typo fixes
Checklist
For bugfixes: