Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set and reset Locale to pass test for non-english contributor. #2622

Merged
merged 7 commits into from
Apr 6, 2024

Conversation

Jaehwa-Noh
Copy link
Contributor

@Jaehwa-Noh Jaehwa-Noh commented Apr 1, 2024

Description

When I build code on local machine, some tests failed because of current language setting.
See this issue.
Fixes #2621

Then I temporary set the default language from Default to English.

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

Copy link
Collaborator

@paul-dingemans paul-dingemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tnx for reporting an fixing. Please address the remarks.

@Jaehwa-Noh
Copy link
Contributor Author

Thank you for reviewing.
I'd changed what you addressed.

@paul-dingemans paul-dingemans merged commit 3e67a28 into pinterest:master Apr 6, 2024
11 checks passed
@paul-dingemans paul-dingemans added this to the 1.2.2 milestone Apr 6, 2024
@paul-dingemans
Copy link
Collaborator

Tnx for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test was not passed when Default language is not English
2 participants