Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#11150] Add WAL durability setting to collector #11151

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Jun 14, 2024

No description provided.

@emeroad emeroad added this to the 3.0.1 milestone Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 47.61905% with 11 lines in your changes missing coverage. Please review.

Project coverage is 37.07%. Comparing base (e50881f) to head (8245318).
Report is 1 commits behind head on master.

Current head 8245318 differs from pull request most recent head 0474422

Please upload reports for the commit 0474422 to get more accurate results.

Files Patch % Lines
...orp/pinpoint/collector/util/DurabilityApplier.java 58.82% 7 Missing ⚠️
.../pinpoint/collector/dao/hbase/HbaseTraceDaoV2.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #11151   +/-   ##
=========================================
  Coverage     37.06%   37.07%           
- Complexity    11991    11995    +4     
=========================================
  Files          3947     3948    +1     
  Lines         97256    97276   +20     
  Branches      10378    10379    +1     
=========================================
+ Hits          36052    36063   +11     
- Misses        58244    58252    +8     
- Partials       2960     2961    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emeroad emeroad merged commit ea6b21f into pinpoint-apm:master Jun 14, 2024
1 check passed
@emeroad emeroad linked an issue Jun 17, 2024 that may be closed by this pull request
@emeroad emeroad deleted the #11150_wal branch June 18, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add WAL durability setting to collector
1 participant