Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#8166] disable sampling flag header can be ignored #8167

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[#8166] disable sampling flag header can be ignored #8167

wants to merge 1 commit into from
+10 −5

Conversation

yjqg6666
Copy link
Contributor

Resolve #8166.

This feature is off by default, can be enabled by setting profiler.sampling.ignoreDisableSamplingFlag=true.

@yjqg6666 yjqg6666 mentioned this pull request Aug 30, 2021
Open
@codecov
Copy link

codecov bot commented Aug 30, 2021 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.28%. Comparing base (77e606c) to head (d979e76).
Report is 1564 commits behind head on master.

❗ Current head d979e76 differs from pull request most recent head 81c1ab3

Please upload reports for the commit 81c1ab3 to get more accurate results.

Files Patch % Lines
...strap/plugin/request/DefaultTraceHeaderReader.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #8167      +/-   ##
============================================
- Coverage     39.80%   39.28%   -0.52%     
+ Complexity    11478    11012     -466     
============================================
  Files          3364     3211     -153     
  Lines         89754    87755    -1999     
  Branches       9950     9864      -86     
============================================
- Hits          35723    34474    -1249     
+ Misses        50979    50279     -700     
+ Partials       3052     3002      -50

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yjqg6666 yjqg6666 requested a review from emeroad August 30, 2021 08:04
@emeroad emeroad added this to the 2.4.0 milestone Sep 24, 2021
@yjqg6666 yjqg6666 force-pushed the ignore-disable-sampling-header branch from d979e76 to 81c1ab3 Compare March 9, 2022 02:03
@yjqg6666
Copy link
Contributor Author

yjqg6666 commented Mar 9, 2022

rebased on the current master.

@emeroad emeroad modified the milestones: 2.4.0, 2.5.0 Apr 20, 2022
@yjqg6666 yjqg6666 mentioned this pull request Aug 17, 2022
Open
@emeroad emeroad modified the milestones: 2.5.0, 2.6.0 Dec 21, 2022
@yjqg6666 yjqg6666 closed this Aug 14, 2023
@yjqg6666 yjqg6666 reopened this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emeroad emeroad Awaiting requested review from emeroad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

[FR.] disable sampling flag header can be ignored (configurable)
2 participants
@yjqg6666 @emeroad