Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR.] disable sampling flag header can be ignored (configurable) #8166

Open
yjqg6666 opened this issue Aug 30, 2021 · 0 comments · May be fixed by #8167
Open

[FR.] disable sampling flag header can be ignored (configurable) #8166

yjqg6666 opened this issue Aug 30, 2021 · 0 comments · May be fixed by #8167

Comments

@yjqg6666
Copy link
Contributor

yjqg6666 commented Aug 30, 2021

Which module is your feature request related to?
Profiling

Is your feature request related to a problem?
What are the considerations when the sampling flag was introduced? From the issues and commit history i haven't found any info about it.

If the topo is gatewayApp (10% sampling) --> bizApp1 (100% profiling) --> bizApp2 . The unsampled request through gatewayApp will add pinpoint header "Pinpoint-Sampled: s0". When the bizApp1 receive the request, it will recognize the header and decide not to trace the request, causing the bizApp1 not 100% profiling.

** Solution
We might make the trace header reader ignore the header and treat it as a new trace and make this behavior configurable, default to not ignore the header for BC. It's open to discussion.

PR #8167 has been made.

yjqg6666 added a commit to yjqg6666/pinpoint that referenced this issue Aug 30, 2021
@yjqg6666 yjqg6666 linked a pull request Aug 30, 2021 that will close this issue
yjqg6666 added a commit to yjqg6666/pinpoint that referenced this issue Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant