Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change collector response to be gRPC client retries friendly #11186

Closed
donghun-cho opened this issue Jun 26, 2024 · 1 comment · Fixed by #11215 or #11225
Closed

Change collector response to be gRPC client retries friendly #11186

donghun-cho opened this issue Jun 26, 2024 · 1 comment · Fixed by #11215 or #11225
Assignees
@donghun-cho
Labels
module:agent module:collector
Milestone
3.0.1

Comments

@donghun-cho
Copy link
Contributor

donghun-cho commented Jun 26, 2024 •
edited
Loading

Change the collector response status code to be gRPC client retries friendly.

  • The expected retryable status codes for the client are [UNKNOWN, UNAVAILABLE]
  • Instead of sending a failure message with status code OK, send the status code UNAVAILABLE as a response.
    • Compatibility with old agents needs to be checked
    • Change response only when the client request includes the gRPC metadata entry retry-friendly-response grpc.built-in.retry with a value of true
@donghun-cho donghun-cho added this to the 3.0.1 milestone Jun 26, 2024
@donghun-cho donghun-cho self-assigned this Jun 26, 2024
donghun-cho added a commit to donghun-cho/pinpoint that referenced this issue Jul 3, 2024
@donghun-cho
[pinpoint-apm#11186] Change gRPC UNARY response based on header value
d7a7988
donghun-cho added a commit to donghun-cho/pinpoint that referenced this issue Jul 3, 2024
@donghun-cho
[pinpoint-apm#11186] Change gRPC UNARY response based on header value
0338829
@donghun-cho donghun-cho linked a pull request Jul 3, 2024 that will close this issue
[#11186] Change gRPC UNARY response based on header value #11215
Merged
donghun-cho added a commit to donghun-cho/pinpoint that referenced this issue Jul 3, 2024
@donghun-cho
[pinpoint-apm#11186] Change gRPC UNARY response based on header value
9b2ccc1
feelform pushed a commit that referenced this issue Jul 3, 2024
@donghun-cho @feelform
[#11186] Change gRPC UNARY response based on header value
2226a97
emeroad added a commit to emeroad/pinpoint that referenced this issue Jul 4, 2024
@emeroad
[pinpoint-apm#11186] Refactor DataSender
0600c59
emeroad added a commit to emeroad/pinpoint that referenced this issue Jul 4, 2024
@emeroad
[pinpoint-apm#11186] Refactor DataSender
ace4044
emeroad added a commit to emeroad/pinpoint that referenced this issue Jul 4, 2024
@emeroad
[pinpoint-apm#11186] Refactor DataSender
cedeee5
emeroad added a commit to emeroad/pinpoint that referenced this issue Jul 5, 2024
@emeroad
[pinpoint-apm#11186] Refactor DataSender
c2c6f7b
emeroad added a commit to emeroad/pinpoint that referenced this issue Jul 5, 2024
@emeroad
[pinpoint-apm#11186] Refactor DataSender
372ec45
emeroad added a commit that referenced this issue Jul 5, 2024
@emeroad
[#11186] Refactor DataSender
9498659
@donghun-cho
Copy link
Contributor Author

Change header key for collector response to grpc.built-in.retry

donghun-cho added a commit to donghun-cho/pinpoint that referenced this issue Jul 8, 2024
@donghun-cho
[pinpoint-apm#11186] Change retry header key for collector response
ec2ef87
@donghun-cho donghun-cho mentioned this issue Jul 8, 2024
Merged
@donghun-cho donghun-cho linked a pull request Jul 8, 2024 that will close this issue
[#11186] Change retry header key for collector response #11225
Merged
donghun-cho added a commit that referenced this issue Jul 8, 2024
@donghun-cho
[#11186] Change retry header key for collector response
e5afaf9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@donghun-cho donghun-cho

Labels
module:agent module:collector
Projects
None yet
Milestone
3.0.1
1 participant
@donghun-cho