Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert -Infinity to null #520

Merged
merged 1 commit into from
Sep 24, 2018
Merged

Conversation

nwoltman
Copy link
Contributor

Building on top of #519, this adds support for converting all invalid number values to null (really the only value left to handle was -Infinity, but this change does it all with one function call).

Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 4b5db27 into pinojs:master Sep 24, 2018
@mcollina
Copy link
Member

good catch and thanks!

@nwoltman nwoltman deleted the handle-negative-infinity branch September 25, 2018 05:18
@github-actions
Copy link

github-actions bot commented Feb 6, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants