Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transports.md #294

Merged
merged 1 commit into from
Sep 21, 2017
Merged

Update transports.md #294

merged 1 commit into from
Sep 21, 2017

Conversation

bloodcarter
Copy link
Contributor

@bloodcarter bloodcarter commented Sep 20, 2017

Update to reflect new functionality: support for AWS Elasticsearch for pino-elasticsearch

Update to reflect new functionality: support for AWS Elasticsearch.
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsumners
Copy link
Member

Would you mind correcting "Check that you defined network.host in your ..." to "Check that your defined network.host in your ..." at the same time?

@bloodcarter
Copy link
Contributor Author

What do you mean? It looks OK now.

@jsumners
Copy link
Member

It's not an error in your change. It's a typo just prior to the text of your change. I'm just asking you'd be willing to make the correction at the same time.

@bloodcarter
Copy link
Contributor Author

@jsumners I got it, but I cannot see the typo in the master.

@jsumners
Copy link
Member

@bloodcarter never mind. I was misreading the text.

Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 7ed1eb7 into pinojs:master Sep 21, 2017
@github-actions
Copy link

github-actions bot commented Feb 8, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants