Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic docsify support #270

Merged
merged 3 commits into from
Jul 25, 2017
Merged

Basic docsify support #270

merged 3 commits into from
Jul 25, 2017

Conversation

mcollina
Copy link
Member

This commit adds docsify support to our docs. Test with

  • npm install docsify-cli -g
  • docsify serve .

Try it and let me know what you think.

schermata 2017-07-23 alle 14 51 54

Fixes #269.

index.html Outdated
<script>
window.$docsify = {
name: 'pino',
loadSidebar: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation says this can be a string path to the sidebar file. How about /docsify/sidebar.md instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll see what I can do.

@@ -0,0 +1,23 @@
<!DOCTYPE html>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this file be in /docs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we place this file in /docs, we would have to duplicate our README. I thought it was preferrable this way.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really unclear about where it is supposed to be placed. The documentation is very lacking in this area (and in general, really).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the basePath configuration variable alleviate needing to update the readme?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The needs come from howe we configure gh-pages. You can configure to use the things in docs/ or in /. If you use the first, you can't access anything in /.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mcollina
Copy link
Member Author

@jsumners I moved the sidebar into the docsify.

Are you folks ok if we publish this? It seems better than nothing :).

@mcollina mcollina merged commit 8665bc6 into master Jul 25, 2017
@mcollina mcollina deleted the docsify branch July 25, 2017 02:32
@github-actions
Copy link

github-actions bot commented Feb 8, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use docsify for the website
2 participants