-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix column mismatch #2785
Fix column mismatch #2785
Conversation
150cd6d
to
63c5c18
Compare
/run-all-tests tidb=release-6.1 tikv=release-6.1 pd=release-6.1 |
/run-all-tests tidb=release-6.1 tikv=release-6.1 pd=release-6.1 |
2 similar comments
/run-all-tests tidb=release-6.1 tikv=release-6.1 pd=release-6.1 |
/run-all-tests tidb=release-6.1 tikv=release-6.1 pd=release-6.1 |
/run-all-tests tidb=release-6.1 tikv=release-6.1 pd=release-6.1 |
/run-all-tests tidb=release-6.1 tikv=release-6.1 pd=release-6.1 |
/run-all-tests tidb=release-6.1 tikv=release-6.1 pd=release-6.1 |
3 similar comments
/run-all-tests tidb=release-6.1 tikv=release-6.1 pd=release-6.1 |
/run-all-tests tidb=release-6.1 tikv=release-6.1 pd=release-6.1 |
/run-all-tests tidb=release-6.1 tikv=release-6.1 pd=release-6.1 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xuanyu66, zhangyangyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
* fix column mismatch * fix * fix index look up fail * opt --------- Co-authored-by: shiyuhang <[email protected]>
* This is an automated cherry-pick of #2785 Signed-off-by: ti-chi-bot <[email protected]> * Update IssueTestSuite.scala * Update IssueTestSuite.scala --------- Signed-off-by: ti-chi-bot <[email protected]> Co-authored-by: shi yuhang <[email protected]>
What problem does this PR solve?
close #2750
fix column mismatch reported by tikv. https://github.com/tikv/tikv/blob/254ceaaa654a70d78919ee5d85f5b4cbe3c444a3/components/tidb_query_executors/src/index_scan_executor.rs#L113
This occurs when the
primary_column_ids
number is more than columns number in the index scan of DAGRequest. Example:What is changed and how it works?
Add primary columns to columns in index scan of DAGRequest when pk is command handle.
Add this because TiDB also do like this. Ref: https://github.com/pingcap/tidb/blob/ddcaadbb856f0890e91e4c77991f0d2aa5aa93d0/pkg/planner/core/planbuilder.go#L1515
Check List
Tests
Code changes
Side effects
Related changes
tidb-ansible
repository