Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Admin Telemetry Statement #908

Merged
merged 2 commits into from
Jun 23, 2020
Merged

Add Admin Telemetry Statement #908

merged 2 commits into from
Jun 23, 2020

Conversation

breezewish
Copy link
Member

What problem does this PR solve?

For pingcap/tidb#18180

What is changed and how it works?

Support the following TiDB specific statements:

ADMIN RESET TELEMETRY_ID
ADMIN SHOW TELEMETRY

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch

@CLAassistant
Copy link

CLAassistant commented Jun 23, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #908 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #908      +/-   ##
==========================================
+ Coverage   78.35%   78.37%   +0.01%     
==========================================
  Files          40       40              
  Lines       14773    14783      +10     
==========================================
+ Hits        11576    11586      +10     
  Misses       2509     2509              
  Partials      688      688              

Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Jun 23, 2020
@kennytm kennytm merged commit b74301a into pingcap:master Jun 23, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 failed

@breezewish breezewish deleted the telemetry branch June 23, 2020 08:29
breezewish added a commit to breezewish/parser that referenced this pull request Jun 23, 2020
kennytm pushed a commit that referenced this pull request Jun 23, 2020
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
* Add telemetry tokens to admin statement

Signed-off-by: Breezewish <[email protected]>

* Merge ADMIN SHOW TELMETRY_ID and ADMIN SHOW TELEMETRY_DATA

Signed-off-by: Breezewish <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants