add a new blog #54
Merged
add a new blog #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidb source code reading 10
xuechunL
reviewed
Jun 14, 2018
tidb-source-code-reading-10.md
Outdated
|
|
||
| Column 的实现参考了Apache Arrow，Column 的代码在 [这里](https://github.com/pingcap/tidb/blob/source-code/util/chunk/chunk.go#L320)。根据所存储的数据类型，我们有两种Column： | ||
|
|
||
| * 定长 Column：存储定长类型的数据，比如：Double、Bigint、Decimal 等 |
There was a problem hiding this comment.
Using Double Bigint Decimal is better. @Husiyu
tidb-source-code-reading-10.md
Outdated
|
|
||
| * 定长 Column：存储定长类型的数据，比如：Double、Bigint、Decimal 等 | ||
|
|
||
| * 变长 Column：存储变长类型的数据，比如：Char、Varchar 等 |
There was a problem hiding this comment.
Using Char Varchar is better.
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@xuechunL PTAL