Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for Tiered Pricing Plans #629

Open
wants to merge 14 commits into
base: original
Choose a base branch
from
Open

Add Support for Tiered Pricing Plans #629

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
471de42
Implementation without Tests
jksimoniii Feb 1, 2019
76cc607
Add Test Cases for Models
jksimoniii Feb 1, 2019
766ed1e
Handle null Amounts in convert_amount_for_db
jksimoniii Feb 1, 2019
f125831
Add Tests for Syncing Plans with Tiers
jksimoniii Feb 1, 2019
271ddfb
Add Tests for ConvertAmountForDBTests
jksimoniii Feb 1, 2019
2c33421
Add Tests for TieredPricingManagerTests
jksimoniii Feb 1, 2019
eb0492f
Fix Failing TieredPricingManagerTests
jksimoniii Feb 1, 2019
b323f9e
Update Tier to Use Decimal Fields
jksimoniii Feb 1, 2019
cbfa6e3
Fix Flake Errors
jksimoniii Feb 1, 2019
0a75829
Fix Django Compatability Issues
jksimoniii Feb 1, 2019
db37888
Use Plan Total Calculator for Subscriptions
jksimoniii Feb 3, 2019
421bb78
Update Migrations
jksimoniii Feb 3, 2019
17a915b
Update Migrations
jksimoniii Feb 3, 2019
4104c7d
Increase Code Coverage
jksimoniii Feb 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix Django Compatability Issues
  • Loading branch information
@jksimoniii
jksimoniii committed Feb 1, 2019
commit 0a75829f3bea57611141a80dbd1a3ff5397e2091
14 changes: 8 additions & 6 deletions pinax/stripe/actions/plans.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,11 @@ def sync_plan(plan, event=None):

if plan["tiers"]:
obj.tiers.all().delete() # delete all tiers, since they don't have ids in Stripe
obj.tiers.set([models.Tier(
plan=obj,
amount=utils.convert_amount_for_db(tier["amount"], plan["currency"]),
flat_amount=utils.convert_amount_for_db(tier["flat_amount"], plan["currency"]),
up_to=tier["up_to"]
) for tier in plan["tiers"]], bulk=False)
for tier in plan["tiers"]:
tier_obj = models.Tier.objects.create(
plan=obj,
amount=utils.convert_amount_for_db(tier["amount"], plan["currency"]),
flat_amount=utils.convert_amount_for_db(tier["flat_amount"], plan["currency"]),
up_to=tier["up_to"]
)
obj.tiers.add(tier_obj)
2 changes: 1 addition & 1 deletion pinax/stripe/managers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def calculate_final_cost(self, plan, quantity, mode):
all_tiers = self.all_tiers(plan)

if mode == self.TIERS_MODE_VOLUME:
applicable_tiers = filter(lambda t: quantity <= t.up_to, all_tiers)
applicable_tiers = list(filter(lambda t: not t.up_to or quantity <= t.up_to, all_tiers))
tier = applicable_tiers[0] if applicable_tiers else all_tiers[-1]
cost = tier.calculate_cost(quantity)
elif mode == self.TIERS_MODE_GRADUATED:
Expand Down