actions: fix sync_account_from_stripe_data #496
Conversation
"transfers_enabled" is not in there by default?! Might only be there after/when rejecting an account (https://stripe.com/docs/api#reject_account). Adding "payouts_enabled" and "support_address".
| "email":"[email protected]", | ||
| "transfers_enabled":true, |
There was a problem hiding this comment.
It fails because "transfers_enabled" is expected to be there, but is not.
Can you shed some light, @lukeburden ?
There was a problem hiding this comment.
https://stripe.com/docs/upgrades#2017-04-06
it has been renamed to payouts_enabled
There was a problem hiding this comment.
Another migration is on its way
There was a problem hiding this comment.
Nice find.
Full docs: https://stripe.com/docs/transfer-payout-split (the renaming is mentioned at the end).
|
mccabe complains now.
workaround: diff --git a/pinax/stripe/actions/accounts.py b/pinax/stripe/actions/accounts.py
index 9d379fb..c3e1686 100644
--- a/pinax/stripe/actions/accounts.py
+++ b/pinax/stripe/actions/accounts.py
@@ -113,9 +113,8 @@ def sync_account_from_stripe_data(data, user=None):
else:
top_level_attrs = common_attrs
- for a in top_level_attrs:
- if a in data:
- setattr(obj, a, data.get(a))
+ for a in [x for x in top_level_attrs if x in data]:
+ setattr(obj, a, data.get(a))
# that's all we get for standard and express accounts!
if data["type"] != "custom":I feel like this is actually not better though. Let's split the function, or ignore mccabe here? |
|
I am closing this, since it conflicts with lock8#73 by itself, and we should have a single PR including both probably?! |
|
@blueyed I️ like McCabe as a guide but we don’t need to be slave to it. If it’s not obvious a way to easily make better let’s ignore. |
|
Hard to ignore it though if the lint job fails then.. But I guess you mean to ignore it for this function then only, which makes sense. |
No description provided.