Refactored code to avoid a deprecation warning in Python 2.7 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try: | ||
| data["error"] = e.args[0] | ||
| except IndexError: | ||
| data["error"] = "Unknown error" |
There was a problem hiding this comment.
This block of code is unreachable due to the 'raise' on line 148 as reported by Travis
************* Module payments.views
W0101:148,12:subscribe: Unreachable code
There was a problem hiding this comment.
Ooops. If I'm correct you don't need line 147. Does that seem right to you?
There was a problem hiding this comment.
Yes in order to render the form errors, if there are any.
There was a problem hiding this comment.
so stripe.StripeError no longer as a message attribute?
|
Without this fix you get the following in the terminal runserver: data["error"] = e.message With this fix you don't get the DeprecationWarning, but you still get the error in the subscribe view. Just like my attached screenshot. |
paltman
added a commit
that referenced
this pull request
Apr 16, 2013
Refactored code to avoid a deprecation warning in Python 2.7
ticosax
added a commit
to ticosax/pinax-stripe
that referenced
this pull request
Oct 27, 2017
We probably need to pass the stripe account
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.