Fix sync_payment_source_from_stripe_data to not crash with sources

[blueyed]

This handles "source" objects now without crashing, but does not create
Card objects from the data therein.

I think that should get done probably?!

Helps with #383.

[codecov]

Codecov Report

Merging #409 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #409      +/-   ##
==========================================
+ Coverage   99.39%   99.39%   +<.01%     
==========================================
  Files          34       34              
  Lines        1651     1652       +1     
  Branches      134      135       +1     
==========================================
+ Hits         1641     1642       +1     
  Misses          5        5              
  Partials        5        5

Flag	Coverage Δ
#py27dj110	99.39% <100%> (ø)	⬆️
#py27dj111	99.39% <100%> (ø)	⬆️
#py27dj18	99.39% <100%> (ø)	⬆️
#py33dj18	99.39% <100%> (ø)	⬆️
#py34dj110	99.39% <100%> (ø)	⬆️
#py34dj111	99.39% <100%> (ø)	⬆️
#py34dj18	99.39% <100%> (ø)	⬆️
#py35dj110	99.39% <100%> (ø)	⬆️
#py35dj111	99.39% <100%> (ø)	⬆️
#py35dj18	99.39% <100%> (ø)	⬆️
#py35djmaster	99.39% <100%> (ø)	⬆️
#py36dj111	99.39% <100%> (ø)	⬆️
#py36djmaster	99.39% <100%> (ø)	⬆️

Impacted Files	Coverage Δ
pinax/stripe/actions/sources.py	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fda68d4...9aca932. Read the comment docs.

[codecov]

Codecov Report

Merging #409 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #409      +/-   ##
==========================================
+ Coverage   99.39%   99.39%   +<.01%     
==========================================
  Files          34       34              
  Lines        1662     1663       +1     
  Branches      135      136       +1     
==========================================
+ Hits         1652     1653       +1     
  Misses          5        5              
  Partials        5        5

Flag	Coverage Δ
#py27dj110	99.39% <100%> (ø)	⬆️
#py27dj111	99.39% <100%> (ø)	⬆️
#py27dj18	99.39% <100%> (ø)	⬆️
#py34dj110	99.39% <100%> (ø)	⬆️
#py34dj111	99.39% <100%> (ø)	⬆️
#py34dj18	99.39% <100%> (ø)	⬆️
#py34dj20	99.39% <100%> (ø)	⬆️
#py35dj110	99.39% <100%> (ø)	⬆️
#py35dj111	99.39% <100%> (ø)	⬆️
#py35dj18	99.39% <100%> (ø)	⬆️
#py35dj20	99.39% <100%> (ø)	⬆️
#py36dj111	99.39% <100%> (ø)	⬆️
#py36dj20	99.39% <100%> (ø)	⬆️

Impacted Files	Coverage Δ
pinax/stripe/actions/sources.py	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a1f3b8...e1e26f2. Read the comment docs.

[blueyed]

This is crucial for webhooks to work correctly when using sources that a not plain card objects.

[blueyed]

IIRC iOS uses card objects, but with Android you get them wrapped in Source objects.

[paltman]

I like the checking against types. More explicit. I'm wondering why I didn't do that in the first place, unless at one point back in the early days we didn't have type. Anyway, I'm +1 on this. Is it still WIP?

[blueyed]

It is good to go as is for now.