-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add support for discounts #321
base: original
Are you sure you want to change the base?
Conversation
'trial_end': trial_end, | ||
} | ||
if coupon: | ||
kwargs.update({'coupon': coupon}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is similar to a change I've got in my PR.
Perhaps we'd both benefit from all kwargs
from this function being passed into stripe.Customer.create
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed, although the main purpose of the PR is to support discount syncing on customer and subscription models.
1 similar comment
7 similar comments
5 similar comments
8 similar comments
1 similar comment
1 similar comment
22 similar comments
Please add tests. I'd like to keep |
ENH: add apply discount to discount model ENH: add discount migration BUG: fix discount key error when no discount exists BUG: convert start and end of discount to tstamps BUG: fix coupon fetch for discount creation BUG: remove stripe_id and created_at from Discount BUG: make discount relationships one to one BUG: migration reflection of discount one to one fields BUG: do not apply discount if end is in the past BUG: change coupon to foreign key on discount BUG: pass customer obj to discount creation instead of stripe customer BUG: update the same discount on sync since there can be only one per customer and sub CLN: bump discount migration up one since 7 is taken in upstream CLN: delete older discount migration BUG: discount migration dependent on coupon migration BUG: discount migration dependent on new 7th migration BUG: fix get or create logic for discount syncing ENH: add quantity to create customer
No description provided.